Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update sidechain cross chain update command schema #7978

Closed
Tracked by #7210
mitsuaki-u opened this issue Jan 11, 2023 · 1 comment
Closed
Tracked by #7210

Update sidechain cross chain update command schema #7978

mitsuaki-u opened this issue Jan 11, 2023 · 1 comment
Milestone

Comments

@mitsuaki-u
Copy link
Contributor

Expected behavior

Update existing schema with updated fields from below schema:

crossChainUpdateTransactionParams = {
    "type": "object",
    "required": [
        "sendingChainID",
        "certificate",
        "activeValidatorsUpdate",
        "certificateThreshold",
        "inboxUpdate"
    ],
    "properties": {
        "sendingChainID": {
            "dataType": "bytes",
            "length": CHAIN_ID_LENGTH,
            "fieldNumber": 1
        },
        "certificate": {
            "dataType": "bytes",
            "fieldNumber": 2
        },
        "activeValidatorsUpdate": {
            "type": "object",
            "fieldNumber": 3,
            "required": [
                "blsKeysUpdate",
                "bftWeightsUpdate",
                "bftWeightsUpdateBitmap"
            ],
            "properties": {
                "blsKeysUpdate": {
                    "type": "array",
                    "fieldNumber": 1,
                    "items": {
                        "dataType": "bytes",
                        "length": BLS_PUBLIC_KEY_LENGTH
                    }
                },
                "bftWeightsUpdate": {
                    "type": "array",
                    "fieldNumber": 2,
                    "items": {
                        "dataType": "uint64",
                    }
                },
                "bftWeightsUpdateBitmap": {
                    "dataType": "bytes",
                    "fieldNumber": 3
                }
            }
        },
        "certificateThreshold": {
            "dataType": "uint64",
            "fieldNumber": 4
        },
        "inboxUpdate": {
            "type": "object",
            "fieldNumber": 5,
            "required": [
                "crossChainMessages",
                "messageWitnessHashes",
                "outboxRootWitness"
            ],
            "properties": {
                "crossChainMessages": {
                    "type": "array",
                    "fieldNumber": 1,
                    "items": {"dataType": "bytes"}
                },
                "messageWitnessHashes": {
                    "type": "array",
                    "fieldNumber": 2,
                    "items": {
                        "dataType": "bytes",
                        "length": HASH_LENGTH
                    }
                },
                "outboxRootWitness": {
                    "type": "object",
                    "fieldNumber": 3,
                    "required": ["bitmap", "siblingHashes"],
                    "properties": {
                        "bitmap": {
                            "dataType": "bytes",
                            "fieldNumber": 1
                        },
                        "siblingHashes": {
                            "type": "array",
                            "fieldNumber": 2,
                            "items": {
                                "dataType": "bytes",
                                "length": HASH_LENGTH
                            }
                        }
                    }
                }
            }
        }
    }
}

Actual behavior

Schema is outdated

Steps to reproduce

Check CCU update logic

Which version(s) does this affect? (Environment, OS, etc...)

development

@Madhulearn Madhulearn added this to the Sprint 87 milestone Jan 17, 2023
@ishantiw
Copy link
Contributor

Superseded by #8014

@ishantiw ishantiw removed this from the Sprint 87 milestone Jan 17, 2023
@Madhulearn Madhulearn added this to the Sprint 87 milestone Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants