Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Clean up LISK32 charset handling #7927

Closed
Tracked by #7226
bobanm opened this issue Jan 2, 2023 · 0 comments · Fixed by #7928
Closed
Tracked by #7226

Clean up LISK32 charset handling #7927

bobanm opened this issue Jan 2, 2023 · 0 comments · Fixed by #7928

Comments

@bobanm
Copy link
Contributor

bobanm commented Jan 2, 2023

There are a few things in Cryptography element which managed to escape from a code review:

  • validateLisk32Address() returns true or never instead of only throwing like most other validate functions
  • There are 2 constants in address.ts defining what BASE32 charset is: CHARSET and LISK32_CHARSET
  • Constants from address.ts could be moved to constants.ts
  • Error messages are not using values from constants but hardcoded literals
  • Test assertions do not need return statement
@bobanm bobanm self-assigned this Jan 2, 2023
@bobanm bobanm changed the title Clean up inconsistencies in Cryptography element Clean up BASE32 handling Jan 2, 2023
@bobanm bobanm changed the title Clean up BASE32 handling Clean up LISK32 charset handling Jul 25, 2023
@shuse2 shuse2 added this to the Sprint 100 milestone Jul 27, 2023
@shuse2 shuse2 closed this as completed Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants