Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update networkID to chainID in the protocol #7442

Closed
Tracked by #7211
ishantiw opened this issue Aug 23, 2022 · 0 comments · Fixed by #7513
Closed
Tracked by #7211

Update networkID to chainID in the protocol #7442

ishantiw opened this issue Aug 23, 2022 · 0 comments · Fixed by #7513
Assignees
@ishantiw
Labels
elements/cryptography framework
Milestone
Sprint 78

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Aug 23, 2022 •
edited
Loading

Description

Use chainID instead of networkID based on PR in the LIP repo

we need to update the places where we use the below functions and pass chainID instead of networkID

  • tagMessage
  • signMessage
  • verifyMessageSig
  • signBLS
  • verifyBLS
  • createAggSig
  • verifyAggSig
  • verifyWeightedAggSig

Acceptance Criteria

  • All the tests should pass in the framework

Additional information

  • Protocol-spec needs to be updated (will be done in a separate Issue)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
elements/cryptography framework
Projects
None yet
Milestone
Sprint 78
Development

Successfully merging a pull request may close this issue.

Update networkIdentifier to chainID LiskArchive/lisk-sdk
2 participants
@milenagojkovic @ishantiw