Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update commander to be compatible with new format of id's #7265

Closed
Tracked by #7210
Incede opened this issue Jun 29, 2022 · 0 comments · Fixed by #7262
Closed
Tracked by #7210

Update commander to be compatible with new format of id's #7265

Incede opened this issue Jun 29, 2022 · 0 comments · Fixed by #7262

Comments

@Incede
Copy link
Contributor

Incede commented Jun 29, 2022

Expected behavior

With #7262 all id types are converted to bytes. Lisk commander should be able to process user inputs and be compatible with the new formats.

Actual behavior

Lisk commander accepts integers for id's as inputs and uses them as it is. As such it is not compatible with the the new format.

Steps to reproduce

Use Lisk commander or yarn test with branch 7090-id

Acceptance Criteria

All tests under commander should pass

Which version(s) does this affect? (Environment, OS, etc...)

6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants