Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update nodejs version to latest LTS #7062

Closed
shuse2 opened this issue Mar 2, 2022 · 1 comment
Closed

Update nodejs version to latest LTS #7062

shuse2 opened this issue Mar 2, 2022 · 1 comment
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Mar 2, 2022

Description

Update minimum required node.js version to 16 for all the packages.
Additionally, it should include #6810 changes for node 16

Motivation

Node 12 LTS is ending at 2022-04-30

@shuse2
Copy link
Collaborator Author

shuse2 commented Mar 15, 2022

11:07:19 INFO lisk-framework: Current Lisk PID (module=lisk:app)
TypeError: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (44518)
    at writeFile (node:fs:2106:5)
    at go$writeFile (~/Documents/10_lisk/lisk-sdk/node_modules/graceful-fs/graceful-fs.js:139:14)
    at Object.writeFile (~/Documents/10_lisk/lisk-sdk/node_modules/graceful-fs/graceful-fs.js:136:12)
    at ~/Documents/10_lisk/lisk-sdk/node_modules/fs-extra/node_modules/universalify/index.js:8:12
    at new Promise (<anonymous>)
    at Object.writeFile (~/Documents/10_lisk/lisk-sdk/node_modules/fs-extra/node_modules/universalify/index.js:7:14)
    at Application._validatePidFile (~/Documents/10_lisk/lisk-sdk/framework/src/application.ts:405:12)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Application.run (~/Documents/10_lisk/lisk-sdk/framework/src/application.ts:259:3)
    at StartCommand.run (~/Documents/10_lisk/lisk-sdk/commander/src/bootstrapping/commands/start.ts:225:4)

On version 16, fs.write must be string but application.ts:405 is saving as number

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants