Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Make Lisky handle improper exits #523

Closed
Tschakki opened this issue May 14, 2018 · 3 comments
Closed

Make Lisky handle improper exits #523

Tschakki opened this issue May 14, 2018 · 3 comments

Comments

@Tschakki
Copy link

Tschakki commented May 14, 2018

Description

When lisky is not exited correctly, e.g. by closing the window with an active lisky session, the .lock file is not cleaned up, and causes the error the next time you try to start lisky.
As this might happen from time to time, I was wondering if there is a way to clean up the .lock file if a session is closed while a lisky process runs on it.

Steps to Reproduce

  1. Open terminal
  2. type lisky
  3. Close terminal
  4. Open terminal
  5. type lisky

Expected behavior:
Lisky should start. Or Lisky should offer an option to recover my old session.

Actual behavior:
The error Config lockfile at /path/to/lisky/config.lock found. Are you running Lisky in another process? is thrown.
I need to remove the lock file manually to make it work again.
Reproduces how often: 100%

Versions

macOS

@shuse2
Copy link
Contributor

shuse2 commented May 14, 2018

I feel like if we don't have interactive mode, it wouldn't be a problem.
We should discuss as a CLI tool, if we really need the interactive mode or not.

@willclarktech
Copy link
Contributor

#525

@shuse2
Copy link
Contributor

shuse2 commented Jul 30, 2018

This is fixed by #533

@shuse2 shuse2 closed this as completed Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants