Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: imports have bad quality #704

Closed
1 task done
MrGumpIT opened this issue May 14, 2024 · 6 comments
Closed
1 task done

[Bug]: imports have bad quality #704

MrGumpIT opened this issue May 14, 2024 · 6 comments
Assignees
@CodeDoctorDE
Labels
bug Something isn't working confirmed
Milestone
2.1

Comments

@MrGumpIT
Copy link
Contributor

What happened?

I believe that some changes to the canvas have led to poor quality of the imported files, this happens with both PDFs and images. It is very noticeable when using zoom. It doesn't seem to happen in the stable version, but in the others it does.

Version

all except stable

Platform

Windows

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MrGumpIT MrGumpIT added the bug Something isn't working label May 14, 2024
@CodeDoctorDE
Copy link
Member

Can you explain it more?
Which exac version did you test? 2.1.0? 2.1.1-rc.0?
Did it change with your pr?
Can you send a screenshot?

@MrGumpIT
Copy link
Contributor Author

I think the problem is due to the zoom. when I zoom in and out the quality drops dramatically. I don't know if there is a solution.

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented May 16, 2024 •
edited
Loading

image

bug reproducable, feel free to create a pr for a fix

@MrGumpIT
Copy link
Contributor Author

how does zoom work, what parts of code should I look at?

@MrGumpIT MrGumpIT mentioned this issue May 17, 2024
Merged
@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented May 17, 2024 •
edited
Loading

zoom just changes the state in transformcubit, that will be used inside the paint methods of the image renderers that will be executed in the viewpainter

@CodeDoctorDE
Copy link
Member

Fixed in #707 by yourself :)
Should land in 2.1.1-rc.1

@CodeDoctorDE CodeDoctorDE added this to the 2.1 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeDoctorDE CodeDoctorDE

Labels
bug Something isn't working confirmed
Projects
Butterfly
Archived in project
Milestone
2.1
Development

No branches or pull requests
2 participants
@CodeDoctorDE @MrGumpIT