Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not refreshing completely on change. #37

Open
Bolado opened this issue May 16, 2024 · 8 comments
Open

Image not refreshing completely on change. #37

Bolado opened this issue May 16, 2024 · 8 comments

Comments

@Bolado
Copy link

Bolado commented May 16, 2024

I'm using a NodeMCU v3 with an ILI9341 display, I was able to make the touch works and displaying the image from the connected VNC machine, but on image change, artifacts appears, like it doesnt update correctly, I show on this video the issue, any direction to fix this issue would be welcome.

@TheNitek
Copy link
Collaborator

Which encoding are you using?

@TheNitek
Copy link
Collaborator

Oh and which code version? Latest release or master from this repo? If it is the release, maybe try the latest master

@Bolado
Copy link
Author

Bolado commented May 27, 2024

Oh and which code version? Latest release or master from this repo? If it is the release, maybe try the latest master

I cloned the repo, haven't used the release as it was quite old compared to the state of the repo.

Which encoding are you using?

I haven't changed the VNC_config.h to be honest, so I would guess it's trying to use those three below? Or how would I be able to set the encoding? I searched if was on server side, but xtigervnc has no arguments to set the encoding.

#define VNC_RRE
#define VNC_CORRE
#define VNC_HEXTILE```

@TheNitek
Copy link
Collaborator

Whats the output in the serial monitor?
you can uncomment the VNC_ZLIB line in the config file (ignore the comment that this is not implemented) and see if it changes the behavior

@Bolado
Copy link
Author

Bolado commented May 27, 2024

Whats the output in the serial monitor? you can uncomment the VNC_ZLIB line in the config file (ignore the comment that this is not implemented) and see if it changes the behavior

I tried it, then it doesn't compile because of this error

 #include "miniz.h"

then I try to include miniz and it fails to compile because of this error:

VNC.cpp:1635: undefined reference to `tinfl_decompress'
collect2.exe: error: ld returned 1 exit status

@TheNitek
Copy link
Collaborator

Oh sorry, zlib only works on the ESP32 (or at least is only tested there).

what is the output on the serial monitor? Maybe remove lines 99 to 103 in the config to get full debug output

@Bolado
Copy link
Author

Bolado commented May 28, 2024

Oh sorry, zlib only works on the ESP32 (or at least is only tested there).

what is the output on the serial monitor? Maybe remove lines 99 to 103 in the config to get full debug output

Sorry for delay, on the serial debug to be honest a lot of the same, handlers for raw and hextile encoding:

[_handle_raw_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] x: 52 y: 5 w: 16 h: 7!
[_handle_hextile_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] x: 52 y: 5 w: 16 h: 7!
[_handle_hextile_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] x: 52 y: 5 w: 16 h: 7!
[_handle_raw_encoded_message] x: 52 y: 5 w: 16 h: 7 bytes: 224!
[_handle_raw_encoded_message] msgPixel: 112 msgSize: 224
[_handle_raw_encoded_message] Pixel left: 112
[_handle_raw_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] ------------------------ Fin ------------------------
[_handle_hextile_encoded_message] x: 52 y: 5 w: 16 h: 7!
[_handle_hextile_encoded_message] ------------------------ Fin ------------------------```

If you need something more specific , lmk

@TheNitek
Copy link
Collaborator

VNC_FRAMEBUFFER is enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants