Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOLOConfiguration does not support number of channels!=3 #805

Closed
kfirgedal opened this issue Feb 17, 2022 · 6 comments · Fixed by #806
Closed

YOLOConfiguration does not support number of channels!=3 #805

kfirgedal opened this issue Feb 17, 2022 · 6 comments · Fixed by #806
Labels
bug Something isn't working help wanted Extra attention is needed won't fix This will not be worked on

Comments

@kfirgedal
Copy link
Contributor

Hi,

YOLOConfiguration implementation does not allow you to provide a number of channels in the .cfg file that is different than 3.

The line that is causing the problem is:
https://github.com/PyTorchLightning/lightning-bolts/blob/2415b49a2b405693cd499e09162c89f807abbdc4/pl_bolts/models/detection/yolo/yolo_config.py#L43

Thanks

@kfirgedal kfirgedal added fix fixing issues... help wanted Extra attention is needed labels Feb 17, 2022
@senarvi
Copy link
Contributor

senarvi commented Feb 25, 2022

That's right, the number of channels in the input image is always 3 (RGB). @kfirgedal is there a way to specify the number of channels in the Darknet implementation?

@kfirgedal
Copy link
Contributor Author

kfirgedal commented Feb 25, 2022

@senarvi
Copy link
Contributor

senarvi commented Feb 25, 2022

@kfirgedal indeed you're right. It should be trivial to add support for that. I can take a look at it soon, unless you want to create a pull request. I'm currently working on a big update that would bring features from YOLOv5, YOLOX, and Scaled-YOLOv4.

@kfirgedal
Copy link
Contributor Author

@senarvi
#806

@senarvi
Copy link
Contributor

senarvi commented Feb 26, 2022

@senarvi #806

Oh you already had a pull request. Excellent! I added a small suggestion, but I'm happy with this being merged.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 27, 2022
@Borda Borda closed this as completed in #806 May 4, 2022
@Borda Borda added bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants