Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MANIFEST #68

Merged
merged 5 commits into from
Nov 25, 2022
Merged

Fix MANIFEST #68

merged 5 commits into from
Nov 25, 2022

Conversation

carmocca
Copy link
Contributor

Fixes #67

Can be tested with

python setup.py sdist
cd dist
pip install *
python -c "from lightning_utilities.test.warning import no_warning_call"

@carmocca carmocca self-assigned this Nov 24, 2022
@carmocca
Copy link
Contributor Author

I can't repro the pre-commit failure locally :(

@Borda
Copy link
Member

Borda commented Nov 24, 2022

I can't repro the pre-commit failure locally :(

I think I have it locally too, but not sure how to fix it

@carmocca carmocca merged commit 8b65753 into main Nov 25, 2022
@carmocca carmocca deleted the bug/fix-manifest branch November 25, 2022 13:16
@carmocca carmocca mentioned this pull request Nov 25, 2022
Merged
@Borda Borda mentioned this pull request Nov 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import lightning_utilities.test.warning.no_warning_call
3 participants
@carmocca @Borda @awaelchli