Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing/1.8.4 extra #15952

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Releasing/1.8.4 extra #15952

merged 3 commits into from
Dec 8, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 8, 2022 •
edited by github-actions bot
Loading

What does this PR do?

adding a few extra commits

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@ethanwharris @Borda
[App] Remove SingleProcessRuntime (#15933)
42494b6 
* Remove SingleProcessRuntime
* Remove unused queues
* Docs

(cherry picked from commit e250dfe)
@ethanwharris @Borda
[App] Fix bug when using structures with works (#15911)
5a25156 
* Fix bug when using structures with works
* Add test
* Update CHANGELOG.md

(cherry picked from commit 1283226)
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

⚠️ This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you push a new commit, all of CI will re-trigger ⚠️ If you have any other questions, you can reach out to carmocca for help.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.9, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) in_progress ⌛
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅
🟢 pytorch_lightning: Benchmarks
Check ID Status
pytorch-lightning.Benchmark success ✅
🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅
🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅
🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅
🔴 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) failure ❌
build-cuda (3.9, 1.11, 11.3.1) failure ❌
build-cuda (3.9, 1.12, 11.6.1) failure ❌
build-cuda (3.9, 1.13, 11.6.1) failure ❌
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.9) success ✅
build-NGC failure ❌
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅
🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🔴 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) failure ❌
🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅
🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅
🟢 mypy
Check ID Status
mypy success ✅
🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

This comment was automatically generated and updates for 60 minutes every 180 seconds.

Thank you for your contribution! 💜

@Borda Borda added the release label Dec 8, 2022
@ethanwharris @Borda
[App] Wait for full file to be transferred in Path / Payload (#15934)
b8e57e8 
* Wait for full file to be transferred in Path / Payload
* Fixes

(cherry picked from commit b8c7018)
@williamFalcon williamFalcon merged commit e0e75d1 into release/stable Dec 8, 2022
@williamFalcon williamFalcon deleted the releasing/1.8.4 branch December 8, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @williamFalcon @ethanwharris