Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value of 'precision' in Fabric() should be '32-true' #18918

Closed
shihaoyin opened this issue Nov 2, 2023 · 1 comment · Fixed by #18928
Closed

The default value of 'precision' in Fabric() should be '32-true' #18918

shihaoyin opened this issue Nov 2, 2023 · 1 comment · Fixed by #18928
Labels
bug Something isn't working ver: 2.2.x
Milestone

Comments

@shihaoyin
Copy link
Contributor

Bug description

The default value of 'precision' in Fabric() should be '32-true', because it crash when using CLI (precision=16 ).

What version are you seeing the problem on?

master

How to reproduce the bug

fabric = Fabric()

# lightning run model train.py --precision=16
# ERROR: Your code has `Fabric(precision=None, ...)` but it conflicts with the value `--precision=16` set through the CLI.

Error messages and logs

# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info

No response

@shihaoyin shihaoyin added bug Something isn't working needs triage Waiting to be triaged by maintainers labels Nov 2, 2023
@carmocca
Copy link
Contributor

carmocca commented Nov 3, 2023

Hi! Thanks for reporting this. I believe #18928 should fix this

@carmocca carmocca removed the needs triage Waiting to be triaged by maintainers label Nov 3, 2023
@carmocca carmocca added this to the 2.1.x milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ver: 2.2.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants