MLFlow logger bug

[riklopfer]

Bug description

Wrong variable used

https://github.com/Lightning-AI/lightning/blob/8f736372ed27a9d3211febc4b8bbdd337b91dad1/src/pytorch_lightning/loggers/mlflow.py#L250

How to reproduce the bug

No response

Error messages and logs

  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1159, in _log_hyperparams
    logger.log_hyperparams(hparams_initial)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/lightning_utilities/core/rank_zero.py", line 24, in wrapped_fn
    return fn(*args, **kwargs)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/pytorch_lightning/loggers/mlflow.py", line 252, in log_hyperparams
    self.experiment.log_batch(run_id=self.run_id, params=params_list)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/tracking/client.py", line 965, in log_batch
    self._tracking_client.log_batch(run_id, metrics, params, tags)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/tracking/_tracking_service/client.py", line 389, in log_batch
    self.store.log_batch(
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/store/tracking/file_store.py", line 1014, in log_batch
    _validate_batch_log_data(metrics, params, tags)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/utils/validation.py", line 303, in _validate_batch_log_data
    _validate_param(param.key, param.value)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/utils/validation.py", line 150, in _validate_param
    _validate_param_name(key)
  File "/usr/local/Caskroom/miniforge/base/envs/cf-gloss-wsd/lib/python3.9/site-packages/mlflow/utils/validation.py", line 217, in _validate_param_name
    if not _VALID_PARAM_AND_METRIC_NAMES.match(name):
TypeError: expected string or bytes-like object

Environment

Current environment

#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 1.10):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info

No response

[riklopfer]

duplicates #16411