Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page linked in the doc is empty #14393

Closed
JulesGM opened this issue Aug 25, 2022 · 3 comments · Fixed by #16197
Closed

Page linked in the doc is empty #14393

JulesGM opened this issue Aug 25, 2022 · 3 comments · Fixed by #16197
Assignees
@awaelchli
Labels
accelerator: cuda Compute Unified Device Architecture GPU docs Documentation related pl Generic label for PyTorch Lightning package
Milestone
v1.9

Comments

@JulesGM
Copy link
Contributor

JulesGM commented Aug 25, 2022 •
edited by github-actions bot
Loading

accelerators/gpu_advanced.html, referred from accelerators/gpu.html as "Advanced", which itself is a very visible page, is empty.

cc @Borda @rohitgr7 @justusschock @kaushikb11 @awaelchli @akihironitta
@JulesGM JulesGM added the needs triage Waiting to be triaged by maintainers label Aug 25, 2022
@carmocca carmocca added docs Documentation related accelerator: cuda Compute Unified Device Architecture GPU pl Generic label for PyTorch Lightning package and removed needs triage Waiting to be triaged by maintainers labels Aug 26, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 26, 2022
@krishnakalyan3
Copy link
Contributor

@carmocca it would be best if we remove this page right?

@Borda
Copy link
Member

Borda commented Aug 26, 2022

Seem that the cross-link does not work, but you are right that it otherwise duplicated page
https://github.com/Lightning-AI/lightning/blob/master/docs/source-pytorch/accelerators/gpu_advanced.rst#L16

@rohitgr7
Copy link
Contributor

the cross link is not added correctly.

@carmocca carmocca modified the milestones: v1.8, v1.8.x, v1.9 Oct 13, 2022
@awaelchli awaelchli self-assigned this Dec 25, 2022
@awaelchli awaelchli mentioned this issue Dec 26, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awaelchli awaelchli

Labels
accelerator: cuda Compute Unified Device Architecture GPU docs Documentation related pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

Fix inclusion of model_parallel document Lightning-AI/pytorch-lightning
6 participants
@JulesGM @krishnakalyan3 @awaelchli @Borda @carmocca @rohitgr7