Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MPS config for specific datafetching test #14378

Closed
justusschock opened this issue Aug 24, 2022 · 0 comments · Fixed by #14379
Closed

Remove MPS config for specific datafetching test #14378

justusschock opened this issue Aug 24, 2022 · 0 comments · Fixed by #14379
Assignees
Labels
accelerator: mps Apple Silicon GPU tests
Milestone

Comments

@justusschock
Copy link
Member

justusschock commented Aug 24, 2022

🐛 Bug

https://github.com/Lightning-AI/lightning/blob/master/tests/tests_pytorch/utilities/test_fetching.py#L198

Runs on both cuda on mps but tests a cuda-specific feature built on cuda-streams with frequent calls to cuda. This test was failing in #14368 .

I suggest to remove the mps config for this test entirely as it does not make sense!

I did not add this to #14012 as we shouldn't figure out what to properly mock here but just remove the configuration.

cc @Borda @akihironitta @justusschock @awaelchli @carmocca

@justusschock justusschock changed the title Remove MPS config for specific test. Remove MPS config for specific datafetching test Aug 24, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: mps Apple Silicon GPU tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants