Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if build config is incompatible with cloud compute #14278

Closed
awaelchli opened this issue Aug 18, 2022 · 2 comments · Fixed by #14929
Closed

Raise error if build config is incompatible with cloud compute #14278

awaelchli opened this issue Aug 18, 2022 · 2 comments · Fixed by #14929
Labels
app (removed) Generic label for Lightning App package feature Is an improvement or enhancement priority: 2 Low priority task
Milestone

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Aug 18, 2022

🚀 Feature

Generate an error when a custom image is specified through the build config and the default cloud compute is selected.

Motivation

#14125
#14230 (comment)

Pitch

Validate the setting of Work.cloud_compute and Work.build_config. If it is incompatible (e.g. custom image + default cpu), raise an error.

Alternatives

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging PyTorch Lightning, Transformers, and Hydra.

cc @Borda @tchaton @rohitgr7

@awaelchli awaelchli added needs triage Waiting to be triaged by maintainers app (removed) Generic label for Lightning App package feature Is an improvement or enhancement and removed needs triage Waiting to be triaged by maintainers labels Aug 18, 2022
@awaelchli awaelchli added this to the app:0.6 milestone Aug 18, 2022
@hhsecond hhsecond modified the milestones: app:0.6, app:0.6.1 Aug 23, 2022
@hhsecond hhsecond assigned hhsecond and unassigned manskx Aug 23, 2022
@nohalon nohalon assigned adam-lightning and unassigned hhsecond Aug 25, 2022
@hhsecond hhsecond added the priority: 2 Low priority task label Aug 25, 2022
@hhsecond
Copy link
Contributor

Reducing priority since platform is still accepting a custom image for the "default" compute configuration. The backend changes for implementing this and reducing cost of running works is going to happen only in few weeks.

@awaelchli
Copy link
Contributor Author

@hhsecond Would you have a quick look at #14929? It's a very simple addition and could be the placeholder until the backend either supports the custom image or adds an error message of its own. What do you think?

@carmocca carmocca moved this to In Review in Frameworks Planning Oct 13, 2022
@carmocca carmocca modified the milestones: app:0.6.x, v1.9 Oct 13, 2022
Repository owner moved this from In Review to Done in Frameworks Planning Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package feature Is an improvement or enhancement priority: 2 Low priority task
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants