Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Colossal.AI Engine #12733

Closed
siddk opened this issue Apr 12, 2022 · 5 comments · Fixed by #14224
Closed

Integrate Colossal.AI Engine #12733

siddk opened this issue Apr 12, 2022 · 5 comments · Fixed by #14224
Assignees
Labels
feature Is an improvement or enhancement strategy: colossalai (removed) Colossal-AI strategy
Milestone

Comments

@siddk
Copy link

siddk commented Apr 12, 2022

🚀 Feature

Similar to the DeepSpeed/FairScale integrations, it'd be really cool for PyTorch Lightning to expose an API for integrating Colossal.AI.

Motivation

Having 3D parallelism and other optimizations as a simple plugin for PyTorch Lightning would make scaling large models super easy!

Pitch

Colossal AI exposes a simple engine-based API similar to DeepSpeed (https://www.colossalai.org/docs/basics/engine_trainer#engine)... should be straightforward to integrate?

cc @Borda @akihironitta @justusschock

@siddk siddk added the needs triage Waiting to be triaged by maintainers label Apr 12, 2022
@akihironitta akihironitta added feature Is an improvement or enhancement strategy and removed needs triage Waiting to be triaged by maintainers labels Apr 14, 2022
@justusschock
Copy link
Member

Hey @siddk that would be awesome. Would you be interested to contribute? I believe that you are right and the integration should be very similar to DeepSpeed. Maybe it is even possible to factor out some common utilities.

We would really appreciate your contribution and definitely help you to iterate over an initial PR :)

@siddk
Copy link
Author

siddk commented Apr 14, 2022

Hey @justusschock - I wish I had the time, but this would be a high-value feature for both some of the work we're doing on training large models at Stanford (https://crfm.stanford.edu/), and a crucial part of several large-scale projects.

If there was 1-2 members of the team (or other contributors), I'd definitely be down to help test, and provide feedback, I just don't think I'd be able to take on all of this alone.

@Borda Borda added this to the 1.7 milestone Apr 18, 2022
@marsggbo
Copy link
Contributor

marsggbo commented Jul 3, 2022

A good suggestion! Any progress now?

@tchaton
Copy link
Contributor

tchaton commented Jul 17, 2022

Hey @marsggbo @siddk @rohitgr7,

I reached out to Collosal-AI Team hpcaitech/ColossalAI#1330.
Let s see if we can collaborate with their team to address your needs.

We will keep you updated on progresses.

Best,
T.C

@carmocca carmocca modified the milestones: pl:1.7, pl:future Jul 19, 2022
@binmakeswell
Copy link

Hi, thank you for your attention and advice, Colossal-AI Team is willing to help provide support for this feature as soon as possible.

@carmocca carmocca modified the milestones: pl:future, pl:1.8 Aug 19, 2022
@carmocca carmocca mentioned this issue Aug 19, 2022
12 tasks
@Borda Borda moved this to Todo in Frameworks Planning Aug 22, 2022
Repository owner moved this from Todo to Done in Frameworks Planning Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement strategy: colossalai (removed) Colossal-AI strategy
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants