Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use the latest testing packages #11362

Closed
akihironitta opened this issue Jan 7, 2022 · 3 comments · Fixed by #11366
Closed

Always use the latest testing packages #11362

akihironitta opened this issue Jan 7, 2022 · 3 comments · Fixed by #11366
Assignees
Labels
ci Continuous Integration

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Jan 7, 2022

🚀 Enhancement in CI

Currently, "oldest" testing uses the oldest versions of each testing packages. For example, pytest==6.0.0 is used in "oldest" setting where its stable version is pytest==6.2.5 as of now.

You can compare which versions are used in "oldest" and "latest" settings:

Motivation

It'll become less likely to spend time debugging something unrelated to our side.

Pitch

Remove:
https://github.com/PyTorchLightning/pytorch-lightning/blob/59a7ba760548baadf6dbb30864b54cb01c7225a3/.github/set-min-requirements.py#L5

Alternatives

Use old versions of testing packages, e.g. pytest, (which are likely to have some bugs in testing packages

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added the ci Continuous Integration label Jan 7, 2022
@Borda
Copy link
Member

Borda commented Jan 7, 2022

if you set pytest>6.0.0 the oldest replacement is not applied

@akihironitta
Copy link
Contributor Author

@Borda I don't see a huge difference between:

  • using > instead of >= in requirements/test.txt and
  • removing the line above from set-min-requirements.py

but would you recommend I follow your suggestion for all testing packages?

@Borda
Copy link
Member

Borda commented Jan 7, 2022

but would you recommend I follow your suggestion for all testing packages?

fair point, let's remove the line :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants