From d0b101ce20b5945cdf4d31ca745ede19b68b3cd7 Mon Sep 17 00:00:00 2001 From: Ethan Harris Date: Thu, 8 Dec 2022 12:54:08 +0000 Subject: [PATCH] [App] Temporarily disable ready (#15958) --- src/lightning_app/core/app.py | 10 +++++++++- src/lightning_app/core/flow.py | 5 ++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/lightning_app/core/app.py b/src/lightning_app/core/app.py index bcf3c2789098e..2279956f7e118 100644 --- a/src/lightning_app/core/app.py +++ b/src/lightning_app/core/app.py @@ -486,7 +486,15 @@ def _run(self) -> bool: """ self._original_state = deepcopy(self.state) done = False - self.ready = self.root.ready + + # TODO: Re-enable the `ready` property once issues are resolved + if not self.root.ready: + warnings.warn( + "One of your Flows returned `.ready` as `False`. " + "This feature is not yet enabled so this will be ignored.", + UserWarning, + ) + self.ready = True self._start_with_flow_works() diff --git a/src/lightning_app/core/flow.py b/src/lightning_app/core/flow.py index 321e594499089..de079238658a2 100644 --- a/src/lightning_app/core/flow.py +++ b/src/lightning_app/core/flow.py @@ -232,7 +232,10 @@ def __getattr__(self, item): @property def ready(self) -> bool: - """Override to customize when your App should be ready.""" + """Not currently enabled. + + Override to customize when your App should be ready. + """ flows = self.flows return all(flow.ready for flow in flows.values()) if flows else True