Skip to content

Commit

Permalink
[App] Temporarily disable ready (#15958)
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanwharris authored Dec 8, 2022
1 parent 3004f13 commit d0b101c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
10 changes: 9 additions & 1 deletion src/lightning_app/core/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,15 @@ def _run(self) -> bool:
"""
self._original_state = deepcopy(self.state)
done = False
self.ready = self.root.ready

# TODO: Re-enable the `ready` property once issues are resolved
if not self.root.ready:
warnings.warn(
"One of your Flows returned `.ready` as `False`. "
"This feature is not yet enabled so this will be ignored.",
UserWarning,
)
self.ready = True

self._start_with_flow_works()

Expand Down
5 changes: 4 additions & 1 deletion src/lightning_app/core/flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ def __getattr__(self, item):

@property
def ready(self) -> bool:
"""Override to customize when your App should be ready."""
"""Not currently enabled.
Override to customize when your App should be ready.
"""
flows = self.flows
return all(flow.ready for flow in flows.values()) if flows else True

Expand Down

0 comments on commit d0b101c

Please sign in to comment.