fix merge with master

Lightning-AI · Dec 2, 2022 · 2c8392a · 2c8392a
1 parent 4fc094d
commit 2c8392a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/docs/source-app/workflows/byoc/index.rst b/docs/source-app/workflows/byoc/index.rst
@@ -53,7 +53,7 @@ Here's an example:
 Arguments
 ^^^^^^^^^
 
-* cluster_name: The name of the cluster to be created
+* cluster_id: The name of the cluster to be created
 
 .. note:: Cluster names can only contain lowercase letters, numbers, and periodic hyphens ( - ).
 

diff --git a/src/lightning_app/cli/cmd_clusters.py b/src/lightning_app/cli/cmd_clusters.py
@@ -158,10 +158,10 @@ def create(
                 lightning list clusters
 
             To view cluster logs use:
-                lightning show cluster logs {cluster_name}
+                lightning show cluster logs {cluster_id}
 
             To delete the cluster run:
-                lightning delete cluster {cluster_name}
+                lightning delete cluster {cluster_id}
             """
             )
         )

diff --git a/src/lightning_app/cli/lightning_cli_create.py b/src/lightning_app/cli/lightning_cli_create.py
@@ -5,7 +5,7 @@
 import click
 from lightning_cloud.openapi.rest import ApiException
 
-from lightning_app.cli.cmd_clusters import _check_cluster_name_is_valid, AWSClusterManager
+from lightning_app.cli.cmd_clusters import _check_cluster_id_is_valid, AWSClusterManager
 from lightning_app.cli.cmd_ssh_keys import _SSHKeyManager
 
 

diff --git a/tests/tests_app/cli/test_cmd_clusters.py b/tests/tests_app/cli/test_cmd_clusters.py
@@ -106,7 +106,7 @@ def test_delete_cluster_api(api_get: mock.MagicMock, api_delete: mock.MagicMock,
     api_delete.assert_called_once_with(id="test-7", force=False)
 
 
-class Test_check_cluster_name_is_valid:
+class Test_check_cluster_id_is_valid:
     @pytest.mark.parametrize("name", ["test-7", "0wildgoat"])
     def test_valid(self, name):
         assert cmd_clusters._check_cluster_id_is_valid(None, None, name)