Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Fix SaveConfigCallback with DDP spawn #12011

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 19, 2022

What does this PR do?

The CLI argument parser is now pickleable.

Closes #11987

The bug is unreleased, so targeting 1.6

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels Feb 19, 2022
@carmocca carmocca added this to the 1.6 milestone Feb 19, 2022
@carmocca carmocca self-assigned this Feb 19, 2022
@mauvilsa
Copy link
Contributor

@carmocca jsonargparse v4.3.0 has just been released.

@carmocca carmocca force-pushed the bugfix/pickleable-jsonargparse branch from 73195aa to 7cc04d4 Compare February 22, 2022 12:59
@carmocca carmocca marked this pull request as ready for review February 22, 2022 13:19
@carmocca carmocca changed the title Fix SaveConfigCallback with DDP spawn [CLI] Fix SaveConfigCallback with DDP spawn Feb 22, 2022
@carmocca carmocca enabled auto-merge (squash) February 22, 2022 13:31
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Feb 28, 2022
@carmocca carmocca merged commit a9024ce into master Feb 28, 2022
@carmocca carmocca deleted the bugfix/pickleable-jsonargparse branch February 28, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants