Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message for unrecognized command line arguments #12303

Closed
cifkao opened this issue Mar 11, 2022 · 3 comments
Closed

No error message for unrecognized command line arguments #12303

cifkao opened this issue Mar 11, 2022 · 3 comments
Assignees
Labels
3rd party Related to a 3rd-party bug Something isn't working lightningcli pl.cli.LightningCLI

Comments

@cifkao
Copy link

cifkao commented Mar 11, 2022

🐛 Bug

LightningCLI provides no useful error message when an unrecognized commannd line argument is passed.

To Reproduce

Boring model

Expected behavior

Should display an error message saying which argument is unrecognized.

Environment

  • CUDA:
    • GPU:
      • Tesla K80
    • available: True
    • version: 11.1
  • Packages:
    • numpy: 1.21.5
    • pyTorch_debug: False
    • pyTorch_version: 1.10.0+cu111
    • pytorch-lightning: 1.5.10
    • tqdm: 4.63.0
  • System:
    • OS: Linux
    • architecture:
      • 64bit
    • processor: x86_64
    • python: 3.7.12
    • version: #1 SMP Tue Dec 7 09:58:10 PST 2021

cc @carmocca @mauvilsa

@akihironitta akihironitta added the lightningcli pl.cli.LightningCLI label Mar 11, 2022
@mauvilsa
Copy link
Contributor

This seems to be a bug in jsonargparse. Could be a regression introduced in a recent release.

@carmocca carmocca added bug Something isn't working 3rd party Related to a 3rd-party labels Mar 13, 2022
@mauvilsa
Copy link
Contributor

Fixed in commit omni-us/jsonargparse@1dac66a. Will be included in the next release of jsonargparse.

@mauvilsa
Copy link
Contributor

The fix is included in jsonargparse v4.4.0 which has just been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working lightningcli pl.cli.LightningCLI
Projects
None yet
Development

No branches or pull requests

4 participants