This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
support for Trainer.predict method #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=====================================
Coverage 75% 75%
=====================================
Files 74 74
Lines 1641 1653 +12
=====================================
+ Hits 1228 1243 +15
+ Misses 413 410 -3 |
…port_for_trainer_predict
for more information, see https://pre-commit.ci
|
Thanks @RR-28023!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would resolve #260. Is just some additions to the
TransformerDataConfigand theTransformerDataModuleobjects in order to supportTrainer.predict.The model passed to the
Trainermust have a apredict_stepor aforwardmethod implemented (it defaults toforwardif there is nopredict_step) in order forTrainer.predictto work. I've implemented it inTextClassificationTransformer, but eventually would need to be implemented for all nlp tasks.