-
Notifications
You must be signed in to change notification settings - Fork 211
Remove sd2
sound extensions from supported audio extensions
#1409
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 91.79% 92.13% +0.34%
==========================================
Files 286 286
Lines 12861 12861
==========================================
+ Hits 11806 11850 +44
+ Misses 1055 1011 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the error is only for '.sd2' files. Should we not just drop that format from support?
Yeah, let's do that. I agree 💯 I don't see any audio dataset having sd2 file extensions as well. Is it okay if I do this in this PR? |
sd2
sound extensions from supported audio extensions
What does this PR do?
CI is failing, because
SoundFile
(forsd2
extension) doesn't accept fsspec objects. Following raises an error:Error raised:
From discussion, we have decided to remove
sd2
extension from supported audio extensions.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃