Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transistor devices. #29

Open
BlueManedHawk opened this issue May 6, 2019 · 7 comments
Open

Add transistor devices. #29

BlueManedHawk opened this issue May 6, 2019 · 7 comments

Comments

@BlueManedHawk
Copy link

There are currently no transistor devices in the library. Could these please be added?

@dbrgn
Copy link
Contributor

dbrgn commented May 7, 2019

Do you have any concrete parts that you'd want in the library?

@BlueManedHawk
Copy link
Author

I was thinking bipolar transistor devices in the SOT-23-3 format. I've created the models for these in a local library, but I don't know how to add them.

@dbrgn
Copy link
Contributor

dbrgn commented May 7, 2019

Cool! We generally use manufacturer-specific libraries, so you'd create a pull request against the corresponding library. Are you familiar with git and GitHub? (If not, and if you don't have the motivation to learn those things, you could also send us the library element through e-mail and we'll add it.)

If the library for the manufacturer of your library does not yet exist, let me know and we can create one.

You can find our library conventions here.

@BlueManedHawk
Copy link
Author

I skimmed the library conventions, and I feel as though a bipolar transistor in the SOT-23-3 format would be a generic component. Should I do a pull request on this library?

@dbrgn
Copy link
Contributor

dbrgn commented May 8, 2019

I think you can reuse the generic Transistor NPN and Transistor PNP components in the "LibrePCB Base" library, right? (cc @ubruhin)

@BlueManedHawk
Copy link
Author

Yes, but I'm wondering whether I should do a pull request to add the appropriate devices.

@dbrgn
Copy link
Contributor

dbrgn commented May 9, 2019

Yes, definitely! Again, what's the manufacturer of those transistor devices? The LibrePCB Base library is only meant for generic parts, so if for example you have a transistor device from Diodes Incorporated, you'd add it to https://github.com/LibrePCB-Libraries/Diodes_Incorporated.lplib.

In order to easily create a pull request, you can clone the git repository to your local libraries (usually LibrePCB-Workspace/v0.1/libraries/local/ and remove the remote library from LibrePCB-Workspace/v0.1/libraries/remote/.

(We should really create a guide for this process...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants