Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Door animations and SFX unaffected by pausing #504

Open
nalquas opened this issue Mar 22, 2023 · 1 comment
Open

Door animations and SFX unaffected by pausing #504

nalquas opened this issue Mar 22, 2023 · 1 comment
Labels
bug Something isn't working visuals Graphics and Aesthetics
Milestone

Comments

@nalquas
Copy link
Member

nalquas commented Mar 22, 2023

Summary

When pausing while opening/closing doors, the animations and sound effects continue playing. The door logic seems to be correctly paused, though, as the passengers continue entering the (visually already closed) door.

How to reproduce

Steps to reproduce the behavior:

  1. Enter any track (e.g. "Tutorials/Free Driving") using any train (JFR1-Red or JFR1-Grey)
  2. Go to external camera
  3. Close the doors
  4. Pause while the doors are closing and observe

Observed behavior

The door animations continue playing while paused. The passengers still enter the door after unpausing for the time the door would have taken to close.

Also, the door sound effects continue playing while paused.

Expected behavior

The door animations and their sound effects are paused correctly.

Version

  • Game Version: current master (292bf45)

Additional information

Probably related to #503.

Unbenannt.mp4
@nalquas nalquas added bug Something isn't working visuals Graphics and Aesthetics labels Mar 22, 2023
@nalquas nalquas added this to the 0.10 milestone Mar 22, 2023
@nalquas nalquas added this to 0.10 Mar 22, 2023
@github-project-automation github-project-automation bot moved this to Todo in 0.10 Mar 22, 2023
@Jomosoto
Copy link
Member

Jomosoto commented Apr 7, 2023

This, #477 and #503 happen because the wagon and the player are PAUSE_MODE_PROCESS for ingame_pause. Maybe we should change something with ingame_pause to avoid futur bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visuals Graphics and Aesthetics
Projects
Status: Todo
Development

No branches or pull requests

2 participants