Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] : BrnBottomTabBar 中 BrnBottomTabBarDisplayType 自定义设置无效 #186

Closed
5night opened this issue Apr 20, 2022 · 1 comment · Fixed by #192
Closed

[BUG] : BrnBottomTabBar 中 BrnBottomTabBarDisplayType 自定义设置无效 #186

5night opened this issue Apr 20, 2022 · 1 comment · Fixed by #192

Comments

@5night
Copy link

5night commented Apr 20, 2022 •
edited
Loading

如构造函数：
type = items.length <= 3 ? BrnBottomTabBarDisplayType.fixed : BrnBottomTabBarDisplayType.shifting
BrnBottomTabBarDisplayType 只和 tabbar 中 items 的个数有关，和自定义设置无关。
@violinday
Copy link
Collaborator

@5night
经过对代码的 CR，这段代码本意是为了根据 items 设置 BrnBottomTabBarDisplayType，实际使用出现了与使用者预期效果不一致的情况。

后续会提 PR 优化这个问题，谢谢反馈~

@violinday violinday mentioned this issue Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add type attribute and optimize iconColor usage
2 participants
@5night @violinday