Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlighting is slightly off with strings #3

Closed
amtoine opened this issue Oct 10, 2022 · 3 comments
Closed

highlighting is slightly off with strings #3

amtoine opened this issue Oct 10, 2022 · 3 comments

Comments

@amtoine
Copy link

amtoine commented Oct 10, 2022

hello there 👋 😋

i've been using helix for a few days now and really enjoy it 👍

however, i have a slight issue with nushell scripts: see helix-editor/helix#4162

i'm new to all that grammar/syntax stuff, do you have an idea to fix that? 😋
can i help in any way? 😌

cheers 🎉
@LhKipp
Copy link
Owner

LhKipp commented Nov 2, 2022 •
edited
Loading

Hi amtoine,

thanks for your feedback. I've added a fix for your problem at hand.

If you want to be of help next time, you can either open a PR with one of the following:

  • a fix and a minimal test case
  • a minimal failing test case

Cheers

@LhKipp LhKipp closed this as completed Nov 2, 2022
@amtoine
Copy link
Author

amtoine commented Nov 3, 2022

thanks for your feedback. I've added a fix for your problem at hand.

thanks a lot! 😌
to be sure, is the fix 695e3ec..eb95bda on the main branch or only a subset of commits? 😋

If you want to be of help next time, you can either open a PR with one of the following:

  • a fix and a minimal test case
  • a minimal failing test case

not sure i understand how tree-sitter works for now, but got it 😉

This was referenced Nov 3, 2022
Closed
Closed
@amtoine
Copy link
Author

amtoine commented Nov 3, 2022

i've been able to try the new revision and the bad highlighting is gone 🤩
good job man 💪

amtoine added a commit to amtoine/dotfiles that referenced this issue Nov 4, 2022
@amtoine
Revert "(helix) bump tree-sitter-nu to latest revision manually"
b59da95 
This reverts commit 02ec252.
The new `nu` revision of tree-sitter is in the source languages.toml
config file for language server.

Related to LhKipp/tree-sitter-nu#3,
helix-editor/helix#4577 and
helix-editor/helix#4583.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amtoine @LhKipp