This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Sort keys by type, same as IndexedDB Second Edition #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
If someone wants this functionality, please speak up now, because I'm proposing to drop key types other than strings and buffers entirely: #186 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB. This has a performance impact on all operations (any type of read or write) but I'm not doing benchmarks yet, because I strongly believe we must first make a collective decision on the desired behavior, then optimize for that. I'm opening a separate ticket for that discussion.
As for this PR: it's feature-complete. I wrote the comparator by following IDB specs and copied tests from
level-jsto verify it.