Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: switch to classic-level and browser-level #215

Merged
merged 8 commits into from
Mar 25, 2022
Merged

Breaking: switch to classic-level and browser-level #215

merged 8 commits into from
Mar 25, 2022

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Mar 5, 2022 •
edited
Loading

Todo:

To be squashed on merge.

I'm opening this PR early just to say: we're there 🥳

@vweevers
Breaking: switch to classic-level and browser-level
f108dc2 
Replacing `leveldown` and `level-js` respectively, as well as now
unnecessary wrappers like `levelup` and more.

Drops support of Node.js 10. Other breaking changes will be
documented in an upgrade guide.
@vweevers vweevers added the semver-major Changes that break backward compatibility label Mar 5, 2022
@vweevers vweevers mentioned this pull request Mar 5, 2022
Open
43 tasks
@vweevers vweevers marked this pull request as ready for review March 6, 2022 19:26
@vweevers vweevers mentioned this pull request Mar 8, 2022
Merged
@vweevers
Copy link
Member Author

@juliangruber 289a88a

@vweevers
Copy link
Member Author

I'll leave this open for two weeks (until Friday March 25th) to allow for review, because previous parts of the abstract-level effort only made semver-patch tweaks or created new modules. This is the first that makes major changes to an existing module.

ralphtheninja
ralphtheninja approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@vweevers vweevers merged commit ad22b21 into master Mar 25, 2022
@vweevers vweevers deleted the v8 branch March 25, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@juliangruber juliangruber Awaiting requested review from juliangruber

Assignees
No one assigned
Labels
semver-major Changes that break backward compatibility
Projects
Level
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vweevers @ralphtheninja