Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manifest #93

Merged
merged 5 commits into from
Oct 13, 2019
Merged

Add manifest #93

merged 5 commits into from
Oct 13, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 1, 2019

See Level/community#83. Also closes #92.

@vweevers vweevers added the semver-minor New features that are backward compatible label Oct 1, 2019
This was referenced Oct 1, 2019
Closed
Closed
ralphtheninja
ralphtheninja reviewed Oct 1, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
ralphtheninja
ralphtheninja reviewed Oct 1, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@vweevers
Copy link
Member Author

vweevers commented Oct 2, 2019 •
edited
Loading

@ralphtheninja Any ideas to simplify? This thing is kinda cool, but it also crossed my mind that the complexity may not be worth it, if you weigh it against e.g. making approximateSize part of abstract-leveldown again, where it can have a well-defined function signature - and no arguments shenanigans during runtime.

@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

Opening this up for review, because I'm kinda out of ideas.

@vweevers vweevers marked this pull request as ready for review October 4, 2019 18:14
@vweevers vweevers requested a review from ralphtheninja October 4, 2019 18:14
vweevers
vweevers commented Oct 4, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
vweevers
vweevers commented Oct 12, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@vweevers vweevers removed the request for review from ralphtheninja October 12, 2019 09:34
@vweevers vweevers self-assigned this Oct 12, 2019
@vweevers vweevers removed their assignment Oct 13, 2019
ralphtheninja
ralphtheninja approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vweevers vweevers merged commit ecefdca into master Oct 13, 2019
@vweevers vweevers deleted the manifest branch October 13, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
semver-minor New features that are backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode compactRange arguments
2 participants
@vweevers @ralphtheninja