-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental support of AbortSignal
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Nov 14, 2022
Comment on lines
+13
to
+23
// TODO: we should set name to AbortError for web compatibility. See: | ||
// https://dom.spec.whatwg.org/#aborting-ongoing-activities | ||
// https://github.com/nodejs/node/pull/35911#discussion_r515779306 | ||
// | ||
// But I'm not sure we can do the same for errors created by a Node-API addon (like | ||
// classic-level) so for now this behavior is undocumented and folks should use the | ||
// LEVEL_ABORTED code instead. | ||
get name () { | ||
return 'AbortError' | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI
vweevers
commented
Nov 15, 2022
vweevers
commented
Nov 15, 2022
vweevers
added a commit
that referenced
this pull request
Jan 27, 2024
And require error `name` to be `AbortError`, as follow-up for #55 (comment).
vweevers
added a commit
that referenced
this pull request
Jan 27, 2024
vweevers
added a commit
that referenced
this pull request
Jan 27, 2024
And require error `name` to be `AbortError`, as follow-up for #55 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50 I made an early start with this, but I made two mistakes:
iterator.next({ signal })
, rather than in constructor options, i.e.db.iterator({ signal })
. The former would not be accessible in afor await...of
and come with a performance penalty.abortOnClose
(Add hiddenabortOnClose
option to iterators #21) which is a separate issue. I'll leave it at that, because it only matters formany-level
and can be solved and explained later.Anyway, this PR enables the following:
Further explained in the README, for the public API and the private API (second paragraph).
This PR also fixes small bugs in the
open()
andclose()
methods of multiple classes, as follow-up for #50.