Skip to content

Commit

Permalink
Prevent installing crossbeam-channel with default-features="false"
Browse files Browse the repository at this point in the history
Debouncers used to install `crossbeam-channel`,
due to keeping `notify`'s default features enabled
even if their own default features were disabled.

With this change, `crossbeam-channel` will
no longer be installed if `notify-debouncer-*`
as well as `notify` are installed with
`default-features = false`

Fixes notify-rs#549
  • Loading branch information
LeoniePhiline committed Nov 22, 2023
1 parent c4d0470 commit 9a8176a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions notify-debouncer-full/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ name = "notify_debouncer_full"
path = "src/lib.rs"

[features]
default = ["crossbeam"]
default = ["crossbeam","notify/macos_fsevent"]
# can't use dep:crossbeam-channel and feature name crossbeam-channel below rust 1.60
crossbeam = ["crossbeam-channel","notify/crossbeam-channel"]

[dependencies]
notify = { version = "6.1.1", path = "../notify" }
notify = { version = "6.1.1", path = "../notify", default-features = false }
crossbeam-channel = { version = "0.5", optional = true }
file-id = { version = "0.2.1", path = "../file-id" }
walkdir = "2.2.2"
Expand Down
4 changes: 2 additions & 2 deletions notify-debouncer-mini/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ name = "notify_debouncer_mini"
path = "src/lib.rs"

[features]
default = ["crossbeam"]
default = ["crossbeam","notify/macos_fsevent"]
# can't use dep:crossbeam-channel and feature name crossbeam-channel below rust 1.60
crossbeam = ["crossbeam-channel","notify/crossbeam-channel"]

[dependencies]
notify = { version = "6.1.1", path = "../notify" }
notify = { version = "6.1.1", path = "../notify", default-features = false }
crossbeam-channel = { version = "0.5", optional = true }
serde = { version = "1.0.89", features = ["derive"], optional = true }
log = "0.4.17"

0 comments on commit 9a8176a

Please sign in to comment.