Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the temporary util.promisify dependency #546

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Remove the temporary util.promisify dependency #546

merged 3 commits into from
Dec 19, 2019

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented Dec 19, 2019

This util.promisify dependency increases the number of transitive dependencies of xml2js from 3 total => 27 total.

I inlined the implementation for the one place it was being used so that the xml2js library has a low dependency and will install fast.

I manually tested this change on node 12,10,8,6,4 and 0.12

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.727% when pulling 3c2c99a on optoolco:reduce-deps into aefc64a on Leonidas-from-XIV:master.

@Leonidas-from-XIV
Copy link
Owner

Hmm, that's interesting. I am surprised that you can use reject & friends in such old Node versions but the code looks good, passes CI and having fewer dependencies is neat for sure. Thanks for your contribution, merging!

@Leonidas-from-XIV Leonidas-from-XIV merged commit bb266cf into Leonidas-from-XIV:master Dec 19, 2019
@Raynos Raynos deleted the reduce-deps branch December 19, 2019 17:07
@Raynos
Copy link
Contributor Author

Raynos commented Dec 19, 2019

Only node 0.10 does not have global.Promise available ; it's also missing other apis like EventEmitter.prototype.removeAllListeners that causes the tests to fail.

Thanks for merging the contribution, let me know once you've released a new version :)

( git checkout master && npm version patch && git push origin master --tags && npm publish )

I'm excited about having a version of aws-sdk with less dependencies.

@Leonidas-from-XIV
Copy link
Owner

Just pushed 0.4.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants