feature: base64 image convert to attachments #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbenriquez
force-pushed
the
feature/convert-base64-images
branch
2 times, most recently
from
1cb98ef
to
483983f
Compare
This reverts commit 483983f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: base64 image convert to attachments
Some email providers (Google) don't allow inline base64 images in emails i.e![]()
I forked this and try to add it in as a feature and also adding an extra env
EMAIL_CONVERT_BASE64_IMAGESCan be further modified and improved in terms of how code is structured but wanted to get an initial impression from this PR if it's something the maintainers think is worth adding.
Basically this looks for base64 inlines within the body and creates attachments (added to the msg) and references as
cidinside the tags