Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status/navigation system bars colors don't match with application #1649

Closed
MV-GH opened this issue Sep 3, 2024 · 2 comments
Closed

Status/navigation system bars colors don't match with application #1649

MV-GH opened this issue Sep 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@MV-GH
Copy link
Collaborator

MV-GH commented Sep 3, 2024

Jerboa Version

0.0.72

Android Version + Phone

Android 14

Describe The Bug

I think this issue has been going for a while for the navigation bar.

image

This code responsible for the navigation bar.

    // Check for preview mode
    if (LocalContext.current is Activity) {
        val window = (LocalContext.current as Activity).window
        val colorScheme = MaterialTheme.colorScheme

        DisposableEffect(Unit) {
            window.navigationBarColor = colorScheme.surfaceColorAtElevation(3.dp).toArgb()

            onDispose {
                window.navigationBarColor = colorScheme.background.toArgb()
            }
        }
    }

And we used to have a translucent status bar, which made the status bar color match with the background. But that was removed in #1607

To Reproduce

Start application

In the case of a crash or when relevant include the logs

No response

@MV-GH MV-GH added the bug Something isn't working label Sep 3, 2024
@MV-GH
Copy link
Collaborator Author

MV-GH commented Sep 3, 2024

In Jerboa 0.0.60 on Android 12 this is how it used to look. We need to go back to that.

kXAaM7TzCm.mp4

@MV-GH
Copy link
Collaborator Author

MV-GH commented Sep 5, 2024

Its good enough for now.

@MV-GH MV-GH closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant