Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort communities by displayed name rather than by invisible id #1203

Closed
Dakkaron opened this issue Aug 28, 2023 · 3 comments · Fixed by #1205
Closed

Sort communities by displayed name rather than by invisible id #1203

Dakkaron opened this issue Aug 28, 2023 · 3 comments · Fixed by #1205
Labels
enhancement New feature or request

Comments

@Dakkaron
Copy link

Jerboa Version

0.0.44

Android Version + Phone

Android 12, Fairphone 4

Describe The Bug

When opening the side drawer (hamburger icon) the communities are sorted by their identification instead of by their display name, even though only the display name is displayed.

For example, the community "Haupteingang" is after "Linux" and before "Mikrocontroller", because [email protected] (which has the display name "Haupteingang") comes after [email protected] and before [email protected]

To Reproduce

  1. Subscribe to [email protected], [email protected] and [email protected]
  2. Open the side drawer
  3. Communities are sorted in this order: "Linux", "Haupteingang", "Mikrocontroller"

It should be "Haupteingang", "Linux", "Microcontroller".

In the case of a crash or when relevant include the logs

No response

@Dakkaron Dakkaron added the bug Something isn't working label Aug 28, 2023
@MV-GH
Copy link
Collaborator

MV-GH commented Aug 28, 2023

https://github.com/dessalines/jerboa/blob/a5d1b01a6b219ad524d5d97e897e6514058646d5/app/src/main/java/com/jerboa/ui/components/drawer/DrawerActivity.kt#L52

It is already supposed to be sorted by name, what you are suggesting is that we sort by "Title" of a community

@MV-GH MV-GH added enhancement New feature or request and removed bug Something isn't working labels Aug 28, 2023
@Dakkaron
Copy link
Author

Dakkaron commented Aug 29, 2023

Ok, sorry for mixing up the terminology.

My suggestion was to sort by what the user actually sees. Otherwise, from the user's point of view, it's basically random sorting, which makes it quite hard to find the community you are looking for.

@Dakkaron
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants