Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Once" Rewards affecting Filters #84

Open
jnovack opened this issue Jan 14, 2023 · 4 comments
Open

"Once" Rewards affecting Filters #84

jnovack opened this issue Jan 14, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jnovack
Copy link
Contributor

jnovack commented Jan 14, 2023

Describe the bug
For events, there is a "once" award (e.g. for Cinderace, it is an Ability Patch). Even after completing the event, the "once" award is still calculated in filters despite not being available.

To Reproduce

  1. Complete the Cinderace event.
  2. Perform a search on "2x Ability Patches"
  3. You will be stopped on a raid in a few searches.
  4. Perform raid, only 1x Ability Patch is dropped.

Expected behavior
I don't expect the filters to hit the "once" awards at all (option?, thoughts?)

image

@jnovack jnovack added the bug Something isn't working label Jan 14, 2023
@jnovack jnovack changed the title "Once" Rewards affecting Calculations "Once" Rewards affecting Filters Jan 14, 2023
@architdate
Copy link
Collaborator

Well, I don't know general consensus here tbh. I was under the assumption that people would be fine hitting it once as well (maybe i am mistaken however?)

@jnovack
Copy link
Contributor Author

jnovack commented Jan 16, 2023

If you have a filter for 2 APs for a raid you want to farm, and this raid has a "once" AP and a "permanent" AP, it will trigger.

If you have done the event, you no longer get the "once" AP despite the reward showing up every time. Thus, making the 2 AP filter effectively useless as it will hit nearly every day skip.

The work-around is to never count the "Once" items in filter calculations.

@architdate
Copy link
Collaborator

I know the workaround for it, I just am not sure if I should implement it. While it may seem like a good idea in context of an event like Cinderace/Charizard/Greninja, it is possible that random raids also have "Once" rewards. You cannot then farm for these rewards anyway since the raid will disappear (for potential non 7* raids with "Once" in their reward tables).

The solution for this however can be to read RAM to figure out if this "Once" has been triggered or not and then count accordingly. This can even make the display of rewards more intuitive since it wont have stuff like Once written next to the reward anymore, it will be exactly what the user sees.

@jnovack
Copy link
Contributor Author

jnovack commented Jan 16, 2023

The solution...

Well, yeah, of course, that's why I suggested the work-around until the solution is found. And if you are unsure the workaround should be implemented for all users, we have this beautiful new options tabular form, turning it off or on could just be a checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants