-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX node names should not have leading slash #1735
Comments
Code to repro keras error:
|
After removing leading slashes, next error is
It seems that onnx2keras just doesn't understand onnx well, I'm inclined not to push the slash removal (https://github.com/mooskagh/lc0/tree/onnx_slash) either. |
mooskagh
removed
bug
Something isn't working
good first issue
Good for newcomers
labels
Apr 23, 2022
I considered filing bugs in the onnx2keras repo, but the projects doesn't look alive, last commit was a year ago, probably not worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apparently, Keras doesn't like such onnx files, giving the error:
Fix is this:
Remove trailing slashes in this file https://github.com/LeelaChessZero/lc0/blob/master/src/neural/onnx/converter.cc
(basically, replace all
"/
which are not part of+ "/
with"
).The text was updated successfully, but these errors were encountered: