Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The turnChange event should be triggered when current player disconnects #23

Open
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Labels

Comments

@LearningNerd
Copy link
Member

Right now, the turnChange event is only triggered when the server's turn timer goes off. If the current player is disconnected before their turn is over, the app acts as thought the turn has changed, but turnChange is never emitted! This is very unintuitive!

The server should fire the turnChange event both when the turn timer goes off and when the current player disconnects, and the client-side handler functions should be refactored accordingly.

Reminder: be sure to update the flowchart and events list after closing this issue, if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant