Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should fork/edit Gists on behalf of disconnected users #21

Open
2 tasks
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Open
2 tasks

Server should fork/edit Gists on behalf of disconnected users #21

LearningNerd opened this issue Jun 28, 2017 · 0 comments
Labels

Comments

@LearningNerd
Copy link
Member

As outlined in issue #20, if a player disconnects before the end of their turn, the Gist should be forked/edited on their behalf so as not to misattribute their edits to the next player. But here's the problem: the client can't fork or edit the Gist after they've disconnected from the app! So the server will have to handle these edge cases.

Tasks for this issue:

  • Save every player's GitHub access token on the server as part of the game state.
  • On disconnect, the server should check if the current player disconnected before the end of their turn; if so, the server should fork/edit the Gist on the player's behalf before restarting the turn timer and passing control to the next player.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant