Skip to content

Commit

Permalink
Adjusted for comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JPMeehan committed Nov 6, 2024
1 parent 54dad71 commit c9b6f6a
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 15 deletions.
12 changes: 7 additions & 5 deletions src/foundry/client/pixi/core/containers/cached-container.d.mts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { NullishProps } from "../../../../../types/utils.d.mts";

export {};

declare global {
Expand All @@ -16,11 +18,11 @@ declare global {
* The texture configuration to use for this cached container
* @remarks Foundry marked as abstract
*/
static textureConfiguration: {
multisample?: PIXI.MSAA_QUALITY;
scaleMode?: PIXI.SCALE_MODES;
format?: PIXI.FORMATS;
};
static textureConfiguration: NullishProps<{
multisample: PIXI.MSAA_QUALITY;
scaleMode: PIXI.SCALE_MODES;
format: PIXI.FORMATS;
}>;

/**
* A map of render textures, linked to their render function and an optional RGBA clear color.
Expand Down
2 changes: 0 additions & 2 deletions src/foundry/client/pixi/layers/effects/darkness-effects.d.mts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import type { AnyObject } from "../../../../../types/utils.d.mts";

export {};

declare global {
/**
* A layer of background alteration effects which change the appearance of the primary group render texture.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { NullishProps } from "../../../../../types/utils.d.mts";

export {};

declare global {
Expand Down Expand Up @@ -114,12 +116,12 @@ declare global {
* }
* ```
*/
static override textureConfiguration: {
multisample?: PIXI.MSAA_QUALITY;
scaleMode?: PIXI.SCALE_MODES;
format?: PIXI.FORMATS;
mipmap?: PIXI.MIPMAP_MODES;
};
static override textureConfiguration: NullishProps<{
multisample: PIXI.MSAA_QUALITY;
scaleMode: PIXI.SCALE_MODES;
format: PIXI.FORMATS;
mipmap: PIXI.MIPMAP_MODES;
}>;

/** @privateRemarks Including to protect duck typing due to overall similarities b/w DarknessLevelContainer and CachedContainer */
#onChildChange(): void;
Expand Down
2 changes: 1 addition & 1 deletion src/foundry/client/pixi/layers/effects/visibility.d.mts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ declare global {
*/
visionModeData: {
source: foundry.canvas.sources.PointVisionSource.Any | null;
activeLightingOptions: Record<string, unknown>;
activeLightingOptions: VisionMode["_source"]["lighting"];
};

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ declare global {
* If the mask should be reversed.
* @defaultValue `false`
*/
reverse?: boolean;
reverse?: boolean | undefined;

/**
* A texture which defines the mask region.
Expand Down

0 comments on commit c9b6f6a

Please sign in to comment.