Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up plugin-related code #37

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Clean up plugin-related code #37

merged 2 commits into from
Aug 29, 2023

Conversation

alice-i-cecile
Copy link
Contributor

There was a useless method there, and the run condition was very poorly named.

@alice-i-cecile alice-i-cecile added code quality Make the code cleaner or prettier usability Make the APIs easier to use breaking-change Something was changed in the public API labels Aug 29, 2023
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) August 29, 2023 15:12
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) August 29, 2023 15:12
@alice-i-cecile alice-i-cecile merged commit 4d5b5c6 into main Aug 29, 2023
4 checks passed
@alice-i-cecile alice-i-cecile deleted the plugin-improvements branch August 29, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Something was changed in the public API code quality Make the code cleaner or prettier usability Make the APIs easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alice-i-cecile