Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the usability of working with resource pools and the Pool trait #35

Merged
merged 13 commits into from
Aug 29, 2023

Conversation

alice-i-cecile
Copy link
Contributor

See CHANGELOG.md for changes made.

Unfortunately orphan rules greatly restrict our ability to implement a lot of these improvements for all pool types, so we're left with examples to copy-paste.

@alice-i-cecile alice-i-cecile added usability Make the APIs easier to use breaking-change Something was changed in the public API labels Aug 29, 2023
Copy link
Contributor

@sixfold-origami sixfold-origami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise this looks great!

src/ability_state.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) August 29, 2023 20:42
@alice-i-cecile alice-i-cecile merged commit 79962a1 into main Aug 29, 2023
4 checks passed
@alice-i-cecile alice-i-cecile deleted the better-pools branch August 29, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Something was changed in the public API usability Make the APIs easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants