Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more complex Action types #415

Closed
wants to merge 12 commits into from
Closed

Conversation

alice-i-cecile
Copy link
Contributor

@alice-i-cecile alice-i-cecile commented Nov 13, 2023

This is a complex PR: it completely refactors our internals in order to allow support for more complex action types and generally reduce internal jank.

Namely, it:

  1. Removes Actionlike::variants and other methods that assume a finite ordered list of discrete actions.
  2. Passes action types by reference rather than value.
  3. Removes the existing DynamicAction types.

Fixes #412. Fixes #278. Fixes #68.

Remaining items

  • fix tests
  • fix doc tests
  • check examples

@alice-i-cecile alice-i-cecile added enhancement New feature or request code-quality Make the code faster or prettier usability Reduce user friction breaking-change A breaking change that requires a new major version controversial Requires a heightened standard of review labels Nov 13, 2023
@alice-i-cecile
Copy link
Contributor Author

Closing this and doing this in a more incremental way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that requires a new major version code-quality Make the code faster or prettier controversial Requires a heightened standard of review enhancement New feature or request usability Reduce user friction
Projects
None yet
1 participant