-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis - run tests in Firefox #5831
Conversation
Added also Chrome support |
Looks like we'll only be able to turn this on once we sort out the failures on both browsers. |
@mourner yes |
This reverts commit 933f7b5.
Moved Chrome support to separate PR #5845 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ghybs for fixing failing tests!
I think we are ready to merge this! 🎉
I am glad you could solve some test issues by simply specifying the browser width in Travis config! Now probably we should also improve those tests to positively specify the map container width, so that we do not rely on the browser width. For reference, these tests are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
BTW please would you know what exactly the env var DISPLAY=:99.0
is for?
Fair enough, but should it block this PR from merging?
Hmm, good question. It is required when using |
@ghybs Yep, it works without |
No, this was mainly for reference for future improvement, sorry I should have made it clearer. |
That is awesome! Thx @cherniavskii! |
@ghybs Thanks for your help ! :) |
It is possible to run karma tests in Firefox with a virtual screen.
Do not merge before all errors in FF are fixed.
Tests which should be fixed: