Update toolbar inner border radius #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for contributing this fix! A question: from the screenshots in #5360, it looked like you tested this with a touch enabled device (controls have a somewhat thick border rather than a box shadow). Did you try this fix also without touch support (you can do this by manually setting |
Flatten toolbar inner border radius to match grey outline on touch devices (L.Browser.touch = true). fixes Leaflet#5360
newmanw
force-pushed
the
toolbar-inner-border-radius
branch
from
e725d9a
to
7cb90ab
Compare
|
@perliedman thanks for looking at this, you are absolutely correct, sorry about that. Non touch devices look great, I updated the pull request to modify the border radius on touch devices only. Please take a look and let me know if the new changes make more sense. Thanks! |
perliedman
approved these changes
Feb 27, 2017
|
👍 Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten toolbar inner border radius to match grey outline. fixes #5360