-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "at" #30
Comments
I don't have the time to work on the polyfill, but I would be glad to review and merge PRs if anyone wants to do it! |
At a quick glance, that PR correctly renders the gradient as shown in the first post. 👍 However, since the branch is 3 years old now, it has diverged quite a bit from this version. It would need a refactor to get it working with the current version (including support for |
Yeah, that's why I just pointed to it instead of fixing it myself 😛 The diversion is mostly due to a rewrite in es6 I believe, but the core structure should be the same since the plugin hasn't changed it's architecture much. |
Thanks for this polyfill, it's great and slots in perfectly. I notice the docs say that setting the centre point isn't supported. Is adding support for it likely?
Currently the use of
at
seems to be interpreted as a colour somehow. Gradients using the polyfill with a conic gradient which includesat
do not fall back in the way I expect. I would expect that the gradient renders normally at the centre, but instead the behaviour is a bit different.For example, the following gradient:
It renders correctly natively in Chrome:
But renders like this in Firefox using the polyfill:
Additionally, if used with
from
, it throws a JS error, which prevents later conic gradients from rendering.The error:
The text was updated successfully, but these errors were encountered: