-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full rust rewriting and new functionnalities #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 39.52% 41.37% +1.85%
==========================================
Files 22 23 +1
Lines 6080 6209 +129
Branches 249 0 -249
==========================================
+ Hits 2403 2569 +166
- Misses 3585 3640 +55
+ Partials 92 0 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Okay, let's create documentation of this new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By rewriting this program entirely in Rust, I could add new features quickly and get almost the same performance as the C version. Rust language is appropriate for our software. And the rewriting was easy.
However, today, I would like to say what differs in this version:
From the most to the least exciting changes
sr
binary is to execute a task with a rolechsr
binary is to modify the configuration and the RootAsRole policy with command line arguments or fancy terminal interfacecapable
binary determines which capabilities are needed for a program.chsr
needs to be managed with cursive.chsr
. Configurator no longer needs to check it manually; it will be informed as denied.sr
. If a user is added to a group that conflicts with SSD, conflicting roles are forbidden.chsr
.sr
now handles timestamp cookies!sr
doesn't require authentication for every command executed before a certain delay. This is entirely configurable like sudo does.capable
eBPF program is now in Rust. It simplifies the compilation process, which was the main problem with the C version.**
means any path; you could translate it by "anything, everywhere".*
means any direct file on the current path here will be relative to the current working directory.**
was changed toALL
. SoALL
means any command and any arguments. This is because the meaning of**
exists in the glob syntax and could be confusing.